Remove ShopifyCheckoutEventProvider #421
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
We added
modules/@shopify/checkout-sheet-kit/src/ShopifyCheckoutEventProvider.tsxduring prototyping but we don't need to keep it around, this will help simplify integration paths by reusing existing providersThis is technically a breaking change, but it just involves removing a provider so we will document as such to improve the design
I was adding testing and it was quite awkward because we perform the NativeModule import in the Component file
This led to each file having a mock like this:
So I moved it to its own file and created a global mock for it (less we mess with mocking react-native the more predictable our tests will be)
this doesn't affect public interface
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.